Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated host bug with extra_inventory #180

Merged
merged 9 commits into from
Dec 11, 2023

Conversation

CFSNM
Copy link
Collaborator

@CFSNM CFSNM commented Oct 2, 2023

The len and contains method in the module_dispatcher was not aware of the extra inventory, just of the inventory.

Fixes: #135

Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test or two for it to verify that the code works well.

@CFSNM CFSNM temporarily deployed to ack October 2, 2023 10:28 — with GitHub Actions Inactive
@CFSNM CFSNM temporarily deployed to test October 2, 2023 10:28 — with GitHub Actions Inactive
@CFSNM CFSNM temporarily deployed to test October 2, 2023 10:28 — with GitHub Actions Inactive
@CFSNM CFSNM force-pushed the support_extra_inventory_module_dispatcher branch from 2e5c60e to 5285781 Compare October 2, 2023 10:30
@CFSNM CFSNM temporarily deployed to ack October 2, 2023 10:30 — with GitHub Actions Inactive
@CFSNM CFSNM temporarily deployed to test October 2, 2023 10:30 — with GitHub Actions Inactive
@CFSNM CFSNM temporarily deployed to test October 2, 2023 10:31 — with GitHub Actions Inactive
@CFSNM
Copy link
Collaborator Author

CFSNM commented Dec 11, 2023

pre-commit.ci autofix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Even no extra-inventory is specified, extra_inventory_manager will still be initialized.
4 participants