Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

todo fixes & __getattr__ method fix #162

Merged
merged 1 commit into from
Aug 14, 2023
Merged

todo fixes & __getattr__ method fix #162

merged 1 commit into from
Aug 14, 2023

Conversation

Ruchip16
Copy link
Member

@Ruchip16 Ruchip16 commented Aug 14, 2023 •
edited
Loading

precoomit fix was failing due to the todo and fixme comments, hence created the issues for the respective and did instant fix where it was necessary

closes #149

@Ruchip16 Ruchip16 requested a review from a team as a code owner August 14, 2023 06:33
@Ruchip16 Ruchip16 requested review from ssbarnea, audgirka and cidrblock and removed request for a team August 14, 2023 06:33
@Ruchip16 Ruchip16 merged commit 138f61a into ansible:main Aug 14, 2023
14 checks passed
@Ruchip16 Ruchip16 deleted the pre-commit-fix branch August 14, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyamsahoo priyamsahoo priyamsahoo approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea was automatically assigned from ansible-community/devtools

@audgirka audgirka Awaiting requested review from audgirka audgirka was automatically assigned from ansible-community/devtools

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock was automatically assigned from ansible-community/devtools

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Todo: Clarify error handling in __getattr__ method
2 participants
@Ruchip16 @priyamsahoo