Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: install docker package in travis usage #772

Merged
merged 1 commit into from
Mar 16, 2017
Merged

Docs: install docker package in travis usage #772

merged 1 commit into from
Mar 16, 2017

Conversation

popstas
Copy link
Contributor

@popstas popstas commented Mar 14, 2017

After 1.21 update travis builds fails with docker-py driver.
Related: #764, #771

popstas added a commit to viasite-ansible/ansible-role-ssh-keys that referenced this pull request Mar 14, 2017
@@ -59,7 +59,7 @@ A ``.travis.yml`` testing a role named foo1 with the Docker driver.
- sudo apt-get -qq update
- sudo apt-get install -o Dpkg::Options::="--force-confold" --force-yes -y docker-engine
install:
- pip install molecule
- pip install molecule docker
Copy link
Contributor

@retr0h retr0h Mar 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to make this a comment. This assumes everyone will be using docker, when we support a few drivers. Could we change this to a comment?

- pip install molecule
# - pip install required driver (e.g. docker, python-vagrant, shade)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I changed commit. Are you think that anyone will use travis with vagrant or openstack?

@retr0h retr0h merged commit 74a666c into ansible:master Mar 16, 2017
@retr0h retr0h added the v1.22 label Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants