Raise upper constraint for importlib-metadata #3244
Conversation
mwhahaha
requested review from
ssbarnea,
tadeboro and
webknjaz
as code owners
|
I must admit that I see no good reason for setting the upper version bound at all. Since the |
|
I can drop it, however I saw commentary about preventing issues with future versions which is the only reason why I set it. It's likely that we'd just hit a problem in the future when v5 is released |
If there is one thing certain in life, it is the fact that things will break ;) If we add upper bound, things will fail because we will forget to bump it and something will start conflicting with that version. If we do not add the bound, things will fail once the importlib library breaks backward compatibility. I just happen to prefer the last failure because I am forced to keep code working with the latest stable versions of library if at all possible. |
|
Ditto. I'll drop the upper limit and if someone wants it back I'll add it. I'd rather only limit when necesary and this only applies to <3.8 anyway. |
The current version of importlib-metadata is 4.8.1 which works fine even when running python <3.8. By restricting to <2, we're limiting the co-installability of molecule with projects that require higher importlib-metadata.
mwhahaha
force-pushed
the
importlib-metadata
branch
from
6d73b41 to
ce56285
Compare
We were always using the upper-constraints when creating tox environments, however there is currently an issue with molecule and openstack upper-constraints that is preventing it from being used. Until molecule can be fixed to work with openstack upper-constraints, lets drop this configuration. We are already adding the constraints to the doc and release notes jobs. ansible/molecule#3244 Change-Id: I91ebaa059dc2451bba739a0a2de917e2f3c2aa21 Related-Bug: #1942704
* Update tripleo-ansible from branch 'master'
to 949414244467e8436c07c2563643267adfb11a75
- Don't use upper-constraints with molecule
We were always using the upper-constraints when creating tox
environments, however there is currently an issue with molecule and
openstack upper-constraints that is preventing it from being used.
Until molecule can be fixed to work with openstack upper-constraints,
lets drop this configuration. We are already adding the constraints to
the doc and release notes jobs.
ansible/molecule#3244
Change-Id: I91ebaa059dc2451bba739a0a2de917e2f3c2aa21
Related-Bug: #1942704
molecule[1] is not compatible with upper-constraints and it breaks the molecule installation in the tox venv due to version conflicts coming from upper-constraints. In order to fix that, we are limiting the usage of uc only for docs and release notes. [1]. ansible/molecule#3244 Related-Bug: #1942704 Signed-off-by: Amol Kahat <amolkahat@gmail.com> CoAuthored-by: Chandan Kumar (raukadah) <chkumar@redhat.com> Change-Id: Ia35c83c13bd9e38384327630374b3aacebe9007b
* Update tripleo-operator-ansible from branch 'master'
to 8b72a414d647d2ea9e2e393e4da993dfb80194a5
- Merge "Limit the usage of upper-constraints"
- Limit the usage of upper-constraints
molecule[1] is not compatible with upper-constraints and it breaks
the molecule installation in the tox venv due to version conflicts
coming from upper-constraints.
In order to fix that, we are limiting the usage of uc only for
docs and release notes.
[1]. ansible/molecule#3244
Related-Bug: #1942704
Signed-off-by: Amol Kahat <amolkahat@gmail.com>
CoAuthored-by: Chandan Kumar (raukadah) <chkumar@redhat.com>
Change-Id: Ia35c83c13bd9e38384327630374b3aacebe9007b
|
With https://github.com/ansible-community/molecule/blob/c6a456b61f0913d07a991b4d579c864d41ca4d82/.pre-commit-config.yaml#L60 we have I would recommend synchronize both |
|
I temporarily modify the line for my DEB/RPM packaging needs, and it works with |
|
Based on my experience of almost a decade with python package dependencies, setting upper bounds created by far more problems than preventing. If dependency follows semver proves to not matter. The only exception is for packages that we know to be prone to break, so basically ceiling seems to be effective only when a particular dependency broke the project more than once. @mwhahaha thanks for making this. |
We were always using the upper-constraints when creating tox environments, however there is currently an issue with molecule and openstack upper-constraints that is preventing it from being used. Until molecule can be fixed to work with openstack upper-constraints, lets drop this configuration. We are already adding the constraints to the doc and release notes jobs. ansible/molecule#3244 STABLE-Only: This also pins molecule to <3.5 as that requires updates to the metadata structure. Change-Id: I91ebaa059dc2451bba739a0a2de917e2f3c2aa21 Related-Bug: #1942704 (cherry picked from commit 9494142)
The current version of importlib-metadata is 4.8.1 which works fine even
when running python <3.8. By restricting to <2, we're limiting the
co-installability of molecule with projects that require higher
importlib-metadata.
The <2 limit was added as part of #3221, but it's not clear why this version
was selected.
PR Type