Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assure we also run functional tests #3172

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Assure we also run functional tests #3172

merged 1 commit into from
Jul 2, 2021

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jul 2, 2021 •
edited
Loading

  • Assure we do not skip running functional test
  • Temporary disables the 4 broken functional tests, fixes in follow-ups.

Related: #3171

@ssbarnea ssbarnea changed the title Assure we run also run functional tests Assure we also run functional tests Jul 2, 2021
@ssbarnea ssbarnea added the bug label Jul 2, 2021
@ssbarnea ssbarnea force-pushed the fix/func branch 2 times, most recently from 180ca68 to e6cc17a Compare July 2, 2021 10:26
@ssbarnea ssbarnea marked this pull request as ready for review July 2, 2021 12:44
@ssbarnea ssbarnea requested a review from tadeboro as a code owner July 2, 2021 12:44
@ssbarnea ssbarnea merged commit 140661f into master Jul 2, 2021
@ssbarnea ssbarnea deleted the fix/func branch July 2, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeboro tadeboro Awaiting requested review from tadeboro

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ssbarnea