Allow to set login_cmd_template for delegate driver #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…managed case The current code only allows to configure the login command if molecule is configured to use non managed instance but it may be helpful to be able to set it even if the instance is managed. For instance, if the instance (eg a chroot or a container) can be created with the create.yml playbook, which means that this instance is reachable with something else than ssh. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
ssbarnea
changed the title
ssbarnea
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…managed case
The current code only allows to configure the login command
if molecule is configured to use non managed instance but it may
be helpful to be able to set it even if the instance is managed.
For instance, if the instance (eg a chroot or a container) can be
created with the create.yml playbook, which means that this instance is
reachable with something else than ssh.
Signed-off-by: Arnaud Patard apatard@hupstream.com
Please include details of what it is, how to use it, how it's been tested
PR Type