update pyyaml to >=5.1 #2064
Merged
update pyyaml to >=5.1 #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: redshiftzero <jen@freedom.press>
decentral1se
suggested changes
May 25, 2019
setup.cfg
Outdated
| @@ -80,7 +80,7 @@ install_requires = | |||
| Jinja2 >= 2.10.1 | |||
| pexpect >= 4.6.0, < 5 | |||
| psutil == 5.4.6; sys_platform!="win32" and sys_platform!="cygwin" | |||
| PyYAML == 3.13 | |||
| PyYAML >= 5.1 | |||
There was a problem hiding this comment.
Can we also get a < 6 ?
Assuming semantic versioning ... but we should make sure 👍
There was a problem hiding this comment.
Closed
ssbarnea
approved these changes
May 28, 2019
decentral1se
suggested changes
May 28, 2019
ssbarnea
approved these changes
May 28, 2019
decentral1se
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1806
CVE-2017-18342 flags the previously unsafe default yaml load function in pyyaml. Since version 1.0.6 of this project, it looks like the safe loader (
yaml.safe_load) was already used everywhere. This PR just updates to a version of pyyaml that does not have the CVE associated with it.