Move to fileglob loop for yml requirement locations #9945
Conversation
| - "{{project_path|quote}}/collections/requirements.yaml" | ||
| - "{{project_path|quote}}/collections/requirements.yml" | ||
| - "{{project_path|quote}}/requirements.yaml" | ||
| - "{{project_path|quote}}/requirements.yml" |
There was a problem hiding this comment.
@geerlingguy with #106 in mind, am I getting hotter or colder?
Did Ansible itself roll out a combined ansible-galaxy install command that handled both collections and roles? If it did, then using that for the top-level requirements would be preferable.
There was a problem hiding this comment.
Was thinking about ansible/ansible#67843 by @jborean93
and after reading back over that, I believe there's nothing we can really use from it. We still support Ansible 2.9 (which doesn't have the combined command), and we have to specify the roles path, which isn't compatible with the combined roles & collections install command.
So I think this answers the question for me - we have to keep using ansible-galaxy role/collection install forever.
Now I'm questioning if we should install roles from {{project_path|quote}}/requirements.yaml or not.
|
Build succeeded.
|
There was a problem hiding this comment.
look good to me @AlanCoding bringing it down to 2 tasks will make future edits easier and create less bloat.
|
Build succeeded (gate pipeline).
|
|
Is this backwards compatible? I am having some issues with a project that has the requirements in the |
|
yeah, it should be completely backward compatible. If you have some details we'll be interested. |
|
I am getting the following warning when fetching the requirements, could it be related?: https://paste.sr.ht/~fourstepper/8dd481a03cc7389350409efdef37f5908661cdcf |
|
No, that's expected. The aesthetics of it are a drawback of this method. All its saying is that you don't have the |
|
Yeah, my bad. Everything is working fine |
Tower/AWX reads only from <root-project-folder/roles, see: ansible/awx#106 and ansible/awx#9945 Signed-off-by: Daniele De Lorenzi <daniele.delorenzi@fastnetserv.net>
[Ansible] Workaround for Ansible Tower/AWX. Tower/AWX reads only from <root-project-folder>/roles/requirements.yml, see: ansible/awx#106 ansible/awx#9945 Signed-off-by: Daniele De Lorenzi <daniele.delorenzi@fastnetserv.net>
[Ansible] Workaround for Ansible Tower/AWX. Tower/AWX reads only from <root-project-folder>/roles/requirements.yml, see: ansible/awx#106 ansible/awx#9945 Signed-off-by: Daniele De Lorenzi <daniele.delorenzi@fastnetserv.net>
[Ansible] Workaround for Ansible Tower/AWX. Tower/AWX reads only from <root-project-folder>/roles/requirements.yml, see: ansible/awx#106 ansible/awx#9945 Signed-off-by: Daniele De Lorenzi <daniele.delorenzi@fastnetserv.net>
Tower/AWX reads only from /roles/requirements.yml. Due to this it fails to install roles requirements.yml, reference: ansible/awx#106 ansible/awx#9945 So we just reference the playbooks via git submodule
SUMMARY
Overdue followup on #8312
I knew there was more research needed, but didn't know what form it would take until I got my hands dirty.
This entails a look and feel change.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
It has a warning... but I don't dislike it.