Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending approvals badge to application header #9334

Merged

Conversation

mabashian
Copy link
Member

SUMMARY

link ##8372

pending_approvals

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • UI

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

initialCount
);
const [reloadCount, setReloadCount] = useState(false);
const throttledFetch = useThrottle(reloadCount, 1000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could maybe go even higher than 1s in case of tabs but up to you.

</PendingWorkflowApprovalBadge>
</PendingWorkflowApprovals>
</Link>
</PageHeaderToolsItem>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@tiagodread tiagodread self-requested a review February 22, 2021 13:17
Copy link
Contributor

@tiagodread tiagodread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@tiagodread tiagodread added mergeit type:feature prioritized on a feature board and removed state:needs_test labels Feb 22, 2021
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3b1b559 into ansible:devel Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui type:feature prioritized on a feature board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants