-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AceEditor - codemirror replacement #9281
AceEditor - codemirror replacement #9281
Conversation
Build failed.
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
8203471
to
ec070c8
Compare
Build succeeded.
|
Build succeeded.
|
"ansi-to-html": "^0.6.11", | ||
"axios": "^0.21.1", | ||
"codemirror": "^5.47.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😌
Build succeeded.
|
9922fca
to
381f463
Compare
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Code lgtm.
- I lightly tested this, but focused mostly on the details component. There's a few things we're aiming to disable when in
readOnly
mode which I discussed w/ @keithjgrant offline.
That said, we'll want several sets of eyes to take a look.
@keithjgrant do you mind syncing with @one-t before code review is done to get a feel for the impact to the tests? Hopefully it's widespread (coverage), but easy to fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 great job @keithjgrant .
68456be
to
a25081c
Compare
Build succeeded.
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
459bac6
to
6f7a717
Compare
Build succeeded.
|
* fix typing space character * hide cursor when editor doesn't have user focus * show help text any time editor is in focus * fix content shifting when help text appears/disappears * remove 80 character "print limit" line
Build failed.
|
Build failed.
|
Build succeeded.
|
Build failed.
|
Regate |
recheck |
Build succeeded.
|
Regate |
Build succeeded (gate pipeline).
|
…acement AceEditor - codemirror replacement Reviewed-by: John Hill <johill@redhat.com> https://github.com/unlikelyzero
SUMMARY
Replaces CodeMirror component with AceEditor component
Addresses #8905, #8176, #8827
ISSUE TYPE
COMPONENT NAME
NOTES
A note about accessibility/keyboard navigation, since I do some unusual manipulation of
tabIndex
: I based my approach on the way PF handles their CodeEditor component (https://patternfly-react.surge.sh/components/code-editor).When navigating via keyboard, the editor is first highlighted in a non-editable mode. The user can continue to tab through the page to the next input, or they may press Enter to begin editing the code input. While editing, tabs are typed into the input area as normal input. Pressing escape (or Shift-Tab) will leave the editable mode, returning to the "selected" mode, where the user may continue to tab through the page normally.
Mouse navigation works as normal: click the editor to place a cursor and begin typing.