Python: Bump to python 3.8 #8778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
Pausing work on this PR. Work will resume when the execution enviironment work will land. Removing the need for an ansible venv (and only having an awx one) |
|
recheck |
|
Build failed.
|
|
@Spredzy hey, this may impact our ui tests' use of awxkit. Let us know with @ui-qe when you're about 2 days away from merging this and we'll work to get it ready on our side |
|
@Spredzy is this PR still active (it's out of date given the k8s installer -> operator move)? Would it make sense to tackle this later, or do you think we'll update this PR in the near future? |
|
Adding @tiagodread |
Closed
Spredzy
force-pushed
the
bump_to_python38
branch
from
e4b2340
to
380febc
Compare
|
Build failed.
|
Spredzy
force-pushed
the
bump_to_python38
branch
from
380febc
to
8e958db
Compare
|
Build failed.
|
Spredzy
force-pushed
the
bump_to_python38
branch
from
8e958db
to
74dd3ae
Compare
|
Build failed.
|
Spredzy
force-pushed
the
bump_to_python38
branch
from
74dd3ae
to
c2fe052
Compare
|
Build failed.
|
|
@Spredzy has this gone through the API and CLI tests? |
Spredzy
force-pushed
the
bump_to_python38
branch
from
c2fe052
to
5515fb7
Compare
|
Build failed.
|
ryanpetrello
approved these changes
Mar 16, 2021
|
Build succeeded.
|
Spredzy
force-pushed
the
bump_to_python38
branch
from
6b19557
to
9736734
Compare
|
Build succeeded.
|
Spredzy
force-pushed
the
bump_to_python38
branch
from
9736734
to
0f06a73
Compare
|
Build succeeded.
|
Spredzy
force-pushed
the
bump_to_python38
branch
from
0f06a73
to
442ed41
Compare
|
Build failed.
|
|
recheck |
1 similar comment
|
recheck |
|
Build failed.
|
|
Build succeeded.
|
| @@ -83,6 +83,8 @@ defusedxml==0.6.0 | |||
| # social-auth-core | |||
| dictdiffer==0.8.1 | |||
| # via openshift | |||
| distro==1.5.0 | |||
| # via -r /awx_devel/requirements/requirements.in | |||
There was a problem hiding this comment.
You can/should regenerate this with 3.8. Some things will fall out (and you can remove the license files for them)
Or that can be a followup change.
There was a problem hiding this comment.
Will do in a subsequent PR yep
Spredzy
force-pushed
the
bump_to_python38
branch
from
2280b59
to
6d8874d
Compare
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Spredzy
added a commit
to Spredzy/awx
that referenced
this pull request
Apr 1, 2021
The generated based venv from `python3.8 -m venv` vs. `virtualenv -p python38` is different. This changes aims to address the differences. It was introduced as part of the Python 3.8 migration. ansible#8778
Spredzy
added a commit
to Spredzy/awx
that referenced
this pull request
Apr 1, 2021
The generated based venv from `python3.8 -m venv` vs. `virtualenv -p python38` is different. This changes aims to address the differences. It was introduced as part of the Python 3.8 migration. ansible#8778
Spredzy
added a commit
to Spredzy/awx
that referenced
this pull request
Apr 1, 2021
The generated based venv from `python3.8 -m venv` vs. `virtualenv -p python38` is different. This changes aims to address the differences. It was introduced as part of the Python 3.8 migration. ansible#8778
softwarefactory-project-zuul bot
added a commit
that referenced
this pull request
Apr 1, 2021
Add wheel in venv creation The generated based venv from python3.8 -m venv vs. virtualenv -p python38 is different. This changes aims to address the differences. It was introduced as part of the Python 3.8 migration. #8778 Reviewed-by: Shane McDonald <me@shanemcd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Bumping default python used in awx and ansible venv to python 3.8
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION