Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding in inventory to unified job query for analytics #7965

Merged
merged 1 commit into from
Sep 1, 2020
Merged

adding in inventory to unified job query for analytics #7965

merged 1 commit into from
Sep 1, 2020

Conversation

rebeccahhh
Copy link
Member

SUMMARY

adds inventory name and ID to collector

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • API
AWX VERSION
awx: 14.0.0

@rebeccahhh rebeccahhh self-assigned this Aug 21, 2020
@wenottingham
Copy link
Contributor

cc @Ladas - this will need processor support once it lands

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@rebeccahhh rebeccahhh changed the title adding in inventory to unified job query for analytics [WIP] adding in inventory to unified job query for analytics Aug 21, 2020
@rooftopcellist
Copy link
Member

@rebeccahhh it looks like this test might need to be updated based on the test failure -

awx/awx/main/tests/functional/analytics/test_collectors.py

Line 70 in b69b53f

def test_copy_tables_unified_job_query(

@Ladas
Copy link
Contributor

Ladas commented Aug 26, 2020

it will need to join to main_inventory table most likely

@rebeccahhh
Copy link
Member Author

@rooftopcellist actually @Ladas is right, we're going to have to do a table update. I opened this PR quite prematurely 😅
Working on that now.

@rebeccahhh
Copy link
Member Author

Alright updated, should be passing that test now @rooftopcellist

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

jbradberry
jbradberry approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@jbradberry jbradberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me now

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@rebeccahhh rebeccahhh changed the title [WIP] adding in inventory to unified job query for analytics adding in inventory to unified job query for analytics Aug 28, 2020
@rebeccahhh
Copy link
Member Author

@Ladas @notting merging this today is likely

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1c55d10 into ansible:devel Sep 1, 2020
@kdelee
Copy link
Member

kdelee commented Sep 4, 2020

@rebeccahhh in the future you can run YOLO with TESTEXPR=analytics

need to update a test because of the version change for the unified jobs csv

@rooftopcellist rooftopcellist mentioned this pull request Sep 4, 2020
Merged
@rebeccahhh
Copy link
Member Author

rebeccahhh commented Sep 8, 2020 •
edited
Loading

@kdelee good to know, I was on PTO when this merged, I'll work with @rooftopcellist to fix this. 😸
update--should be taken care of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rooftopcellist rooftopcellist rooftopcellist left review comments

@jbradberry jbradberry jbradberry approved these changes

@wenottingham wenottingham wenottingham approved these changes

@beeankha beeankha beeankha approved these changes

@ryanpetrello ryanpetrello Awaiting requested review from ryanpetrello

Assignees

@rebeccahhh rebeccahhh

Labels
component:api type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rebeccahhh @wenottingham @rooftopcellist @Ladas @kdelee @jbradberry @beeankha @awxbot