Prevent exception for Non value

[john-westcott-iv]

SUMMARY

Fixes #7267

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• Collection

AWX VERSION

awx: 11.2.0

ADDITIONAL INFORMATION

This can be tested with the following task:
- name: Handle an omit value
  tower_settings:
    name: AWX_PROOT_BASE_PATH
    value: '{{ junk_var | default(omit) }}'

Without the change you get the stack.
With the new change it now long stacks but will return something like:

fatal: [localhost]: FAILED! => {"changed": false, "msg": "Unable to update settings, see response", "response": {"json": {"AWX_PROOT_BASE_PATH": ["This field may not be null."]}, "status_code": 400}}

[softwarefactory-project-zuul]

Build failed.

• awx-api-lint : FAILURE in 1m 48s
• awx-api : SUCCESS in 10m 41s
• awx-ui : SUCCESS in 3m 27s
• awx-ui-next : SUCCESS in 11m 27s
• awx-swagger : SUCCESS in 8m 12s
• awx-detect-schema-change : SUCCESS in 8m 02s (non-voting)
• awx-ansible-modules : SUCCESS in 2m 18s

[AlanCoding]

if value is None.

[softwarefactory-project-zuul]

Build succeeded.

• awx-api-lint : SUCCESS in 4m 42s
• awx-api : SUCCESS in 11m 36s
• awx-ui : SUCCESS in 8m 01s
• awx-ui-next : SUCCESS in 10m 54s
• awx-swagger : SUCCESS in 10m 35s
• awx-detect-schema-change : SUCCESS in 12m 13s (non-voting)
• awx-ansible-modules : SUCCESS in 5m 10s

[AlanCoding]

double checking tests for merge now

[AlanCoding]

this is producing an integration test failure in tower_settings

  PLAY [testhost] ****************************************************************
  
  TASK [Gathering Facts] *********************************************************
  ok: [testhost]
  
  TASK [tower_settings : Set the value of AWX_PROOT_SHOW_PATHS to a baseline] ****
  changed: [testhost]
  
  TASK [tower_settings : Set the value of AWX_PROOT_SHOW_PATHS to get an error back from Tower] ***
  fatal: [testhost]: FAILED! => {"changed": false, "msg": "Unable to update settings, see response", "response": {"json": {"AWX_PROOT_SHOW_PATHS": ["Expected a list of items but got type \"OrderedDict\"."]}, "status_code": 400}}
  ...ignoring
  
  TASK [tower_settings : assert] *************************************************
  ok: [testhost] => {
      "changed": false, 
      "msg": "All assertions passed"
  }
  
  TASK [tower_settings : Set the value of AWX_PROOT_SHOW_PATHS] ******************
  changed: [testhost]
  
  TASK [tower_settings : assert] *************************************************
  ok: [testhost] => {
      "changed": false, 
      "msg": "All assertions passed"
  }
  
  TASK [tower_settings : Attempt to set the value of AWX_PROOT_BASE_PATH to what it already is] ***
  ok: [testhost]
  
  TASK [tower_settings : debug] **************************************************
  ok: [testhost] => {
      "msg": {
          "changed": false, 
          "failed": false, 
          "old_values": {}, 
          "warnings": [
              "You are using the awx version of this collection but connecting to Red Hat Ansible Tower"
          ]
      }
  }
  
  TASK [tower_settings : assert] *************************************************
  ok: [testhost] => {
      "changed": false, 
      "msg": "All assertions passed"
  }
  
  TASK [tower_settings : Apply a single setting via settings] ********************
  changed: [testhost]
  
  TASK [tower_settings : assert] *************************************************
  ok: [testhost] => {
      "changed": false, 
      "msg": "All assertions passed"
  }
  
  TASK [tower_settings : Apply multiple setting via settings with no change] *****
  ok: [testhost]
  
  TASK [tower_settings : debug] **************************************************
  ok: [testhost] => {
      "msg": {
          "changed": false, 
          "failed": false, 
          "old_values": {}, 
          "warnings": [
              "You are using the awx version of this collection but connecting to Red Hat Ansible Tower"
          ]
      }
  }
  
  TASK [tower_settings : assert] *************************************************
  ok: [testhost] => {
      "changed": false, 
      "msg": "All assertions passed"
  }
  
  TASK [tower_settings : Apply multiple setting via settings with change] ********
  changed: [testhost]
  
  TASK [tower_settings : assert] *************************************************
  ok: [testhost] => {
      "changed": false, 
      "msg": "All assertions passed"
  }
  
  TASK [tower_settings : Handle an omit value] ***********************************
  fatal: [testhost]: FAILED! => {"changed": false, "msg": "Unable to update settings, see response", "response": {"json": {"AWX_PROOT_BASE_PATH": ["This field may not be null."]}, "status_code": 400}}
  
  PLAY RECAP *********************************************************************
  testhost                   : ok=16   changed=4    unreachable=0    failed=1    skipped=0    rescued=0    ignored=1 

falsy API types are a headache. I say that not knowing the exact issue at hand here. I can help reproduce locally if needed.

[softwarefactory-project-zuul]

Build succeeded.

• awx-api-lint : SUCCESS in 2m 49s
• awx-api : SUCCESS in 6m 57s
• awx-ui : SUCCESS in 3m 55s
• awx-ui-next : SUCCESS in 7m 12s
• awx-swagger : SUCCESS in 10m 05s
• awx-detect-schema-change : SUCCESS in 8m 10s (non-voting)
• awx-ansible-modules : SUCCESS in 2m 08s

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).

• awx-api-lint : SUCCESS in 1m 46s
• awx-api : SUCCESS in 9m 56s
• awx-ui : SUCCESS in 3m 35s
• awx-ui-next : SUCCESS in 7m 02s
• awx-swagger : SUCCESS in 11m 29s
• awx-detect-schema-change : SUCCESS in 7m 37s (non-voting)
• awx-ansible-modules : SUCCESS in 2m 16s
• awx-push-new-schema : SUCCESS in 8m 08s (non-voting)