Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded auth props #7244

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Remove unneeded auth props #7244

merged 1 commit into from
Jun 4, 2020

Conversation

jakemcdermott
Copy link
Contributor

SUMMARY

These props don't do anything anymore.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@nixocio
Copy link
Contributor

nixocio commented Jun 4, 2020

@jakemcdermott, the solution using ProtectedRoute is really cool.

@nixocio
Copy link
Contributor

nixocio commented Jun 4, 2020

I got this code locally. It seems to be working fine.

@nixocio nixocio self-requested a review June 4, 2020 12:56
@jakemcdermott
Copy link
Contributor Author

jakemcdermott commented Jun 4, 2020 •
edited
Loading

@jakemcdermott the solution using ProtectedRoute is really cool.

Thanks - this is mostly because of some great feedback from @AlexSCorey. The way we had it originally was a bit more complicated, but after staring at it for a while we realized some of the routing logic was redundant and we found a way to simplify it.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7623257 into devel Jun 4, 2020
@jakemcdermott jakemcdermott deleted the jakemcdermott-remove-auth-props branch July 7, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixocio nixocio nixocio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakemcdermott @nixocio