[WIP] Allow org admins to remove labels #7143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
|
why is this not needed for attaching, in addition to JTs? also curious about that. |
|
👀 |
jbradberry
suggested changes
May 28, 2020
There was a problem hiding this comment.
Based on my investigation just now on the devel branch, the issue is that a TypeError is raised on line 498 due to a typo. Fixing the typo appears to allow an org admin to remove the label without problem, unless there is more to the issue than I realize.
Line 498 in f05bd05
rooftopcellist
force-pushed
the
rm_label_500
branch
from
f05bd05
to
d308620
Compare
|
@jbradberry is absolutely right. I just updated the PR. @AlanCoding It is not needed for attaching, I just reverted my prior change to the unattach method. It looks like this was just a typo in this commit: 4eab362#diff-c14c9d695bfbeb70889f2b42b18ed42dR495 |
|
Build succeeded.
|
AlanCoding
approved these changes
May 28, 2020
|
Build succeeded (gate pipeline).
|
This was referenced Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Org Admin's couldn't unattach a label from a WFJT because the
can_unattach()method in it's access class didn't cover that case.ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
I would like to add a test for this. I am also still investigating why this is not needed for Job Templates. There may be a better place for this fix.