Allow disassociating orphaned users from credentials #6554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
This is preventing removing roles from users no longer in the organization.
wenottingham
changed the title
|
Updated per discussion |
|
Build succeeded.
|
AlanCoding
approved these changes
Apr 3, 2020
|
did some other testing, all green |
|
Build succeeded (gate pipeline).
|
AlanCoding
pushed a commit
to AlanCoding/awx
that referenced
this pull request
Jan 22, 2024
Co-authored-by: Oleksii Baranov <olebaran@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preventing removing roles from users no longer in the organization.
This also now allows granting roles to organization credentials to
users or teams outside of the organization.
SUMMARY
cc @fosterseth @AlanCoding @gamuniz re: whether we want to add this permission. Was there a reason we treated credentials differently here? (The behavior does date back to the Akita RBAC rewrite, so I would understand paranoia here.)
ISSUE TYPE
COMPONENT NAME
AWX VERSION
current