-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set setuid bit on bwrap in development Dockerfile #6063
Merged
softwarefactory-project-zuul
merged 1 commit into
ansible:devel
from
philipsd6:setuid-brwap-dev
Feb 25, 2020
Merged
Set setuid bit on bwrap in development Dockerfile #6063
softwarefactory-project-zuul
merged 1 commit into
ansible:devel
from
philipsd6:setuid-brwap-dev
Feb 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: ansible#5224 Signed-off-by: Philip Douglass <philip.douglass@amadeus.com>
@shanemcd can you review and approve this PR? Thanks! |
shanemcd
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Build succeeded.
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philip Douglass philip.douglass@amadeus.com
SUMMARY
Related: #5224
As noted, due to a change in the way the bubblewrap package installs on CentOS 8 and RHEL 8, the setuid bit must be set on the bwrap binary. While this was fixed for the installer, it was not fixed in the development Dockerfile.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
The problem can be seen as described in #5224 with the development image by following the instructions given in the CONTRIBUTING.md guide to build the development image.