Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes ui-side behavior in response to websocket job status updates on several lists #5968

Merged

Commits on Mar 3, 2020

  1. Changes how the jobs list reacts to socket messages. We now only make…

    … targeted GET requests for new rows. We use the available information in the socket message to update the relevant row (if visible in the list).
    mabashian authored and rebeccahhh committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    60a1372 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    98f5525 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    179c62e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e75f7b0 View commit details
    Browse the repository at this point in the history
  5. Removes logic performing GET requests on api/v2/templates whenever …

    …a job status update message comes across the websocket. We now use data exclusively from the websocket to update the UI.
    mabashian authored and rebeccahhh committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    51a6194 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1fe2846 View commit details
    Browse the repository at this point in the history
  7. Removes GET requests in response to websocket messages on the org job…

    … templates list. List is solely updated based on data from the websocket messages.
    mabashian authored and rebeccahhh committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    a6cd325 View commit details
    Browse the repository at this point in the history
  8. fixed the spelling of cancelled to be canceled, note to us later -> w…

    …e need to stick with a single spelling of the word
    rebeccahhh committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    6d6d99b View commit details
    Browse the repository at this point in the history
  9. Consume finished timestamp from websocket message when it's available…

    … to update the relevant row in the templates list.
    mabashian authored and rebeccahhh committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    3234f24 View commit details
    Browse the repository at this point in the history
  10. Consume finished timestamp from websocket message and update the rele…

    …vant job row. Also adds logic to attempt to re-order the list when the sort order is -finished since we have enough information client-side to do that.
    mabashian authored and rebeccahhh committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    db43341 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d5dd3c5 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b09ac71 View commit details
    Browse the repository at this point in the history
  13. Fix jshint errors

    mabashian authored and rebeccahhh committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    48a6152 View commit details
    Browse the repository at this point in the history
  14. Remove tooltip update when job finishes. This will be handled later d…

    …own the line by buildTooltips().
    mabashian authored and rebeccahhh committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    d3fa34c View commit details
    Browse the repository at this point in the history
  15. Added in check for the unified_job_template_id attribute to be presen…

    …t and populated in the object.
    
    For anyone reading this later, know that AdHocCommands still have unified_job_template and unified_job_template_id fields, they are just nonetypes because they don't get used by the AdHocCommand objects. Which means you have to actually get the object, not just check that it's there, to use it the way I am in this change.
    rebeccahhh committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    e11ff69 View commit details
    Browse the repository at this point in the history
  16. Jobs that error should trigger us to to update the Recent Jobs list a…

    …long with successful/failed/canceled
    mabashian authored and rebeccahhh committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    10b5a10 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    07752f4 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. added a check for the field of finished making sure it's not none, an…

    …d then breaking the DateTime function
    rebeccahhh committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    457dc95 View commit details
    Browse the repository at this point in the history