Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show non-obvious permission holders with arrow notation #4514

Closed
wants to merge 2 commits into from

Conversation

AlanCoding
Copy link
Member

SUMMARY

Here are issues that this addresses, and a corresponding screen shot for those cases:

#4108

Screen Shot 2019-08-19 at 2 28 42 PM

#1087 closed, but the prior solution does not display who has read permission, so this is an outright re-work of #3721

Screen Shot 2019-08-19 at 2 34 45 PM

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • API
AWX VERSION
6.1.0
ADDITIONAL INFORMATION

This is also blocking of #3903

So the real issues this addresses are 3903 and 4108

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@wenottingham
Copy link
Contributor

wenottingham commented Aug 19, 2019

I think this (as a UX) makes it more confusing, and this is probably better fixed on the UI side, or at least with UI help. The key issue is it showing 'admin' when you don't actually have admin....

@AlanCoding
Copy link
Member Author

Yes, this can be done entirely on the UI side. To summarize the JSON data I posed in other issue:

        {
            "id": 8,
            "type": "user",
            "..."
            "summary_fields": {
                "direct_access": [],
                "indirect_access": [
                    {
                        "role": {
                            "name": "Admin",
                            "description": "Can manage all aspects of the organization",
                            "resource_name": "alan",
                            "resource_type": "organization",
                            "..."
                        },
                        "descendant_roles": [
                            "read_role",
                            "use_role"
                        ]
                    }
                ]
            },
            "..."
        }

The meaning of this is

  • "this user has Admin role to the alan organization"
  • "holding this role grants user read & use role to the resource"

Let me know if there are any questions about the meaning of data the API returns. Ping @trahman73, as well.

@AlanCoding
Copy link
Member Author

#4529

@AlanCoding AlanCoding closed this Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants