Remove unused migration methods #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
ryanpetrello
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
@AlanCoding you have no idea how happy it makes me to approve this PR.
|
My motivation is that I'll be touching this file for #3903, and being able to merge this first will help to re-organize the overall structure and documentation of these utilities. |
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had checkpoint releases - where you had to migrate to these before continuing. After those are declared, migration files get deleted.
These are all methods which were only used in migration files which have now been deleted. Now nothing references them. Their logic pertains to state which can now no longer be obtained in current versions of the code.