Unpin django-guid and update license #15381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there's no reason listed for the pin and the changelog doesn't describe any changes that should block a full upgrade. they changed licenses to MIT
github-actions
bot
added
the
dependencies
djyasin
approved these changes
Jul 22, 2024
| @@ -17,7 +17,7 @@ django-auth-ldap | |||
| django-cors-headers | |||
| django-crum | |||
| django-extensions | |||
| django-guid==3.2.1 | |||
There was a problem hiding this comment.
any idea why was this pin in the first place can u go back into git history and find out?
There was a problem hiding this comment.
adding it here for continuity but I went back in the history and we initially upgraded django-guid to bring the version in line with Django 3.2 when we upgraded to that. there was no reason for it being pinned
There was a problem hiding this comment.
Never understood the pin myself. Am author of the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There's no reason listed for the pin and the changelog doesn't describe any changes that should block a full upgrade. They also changed licenses to MIT.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION