Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the receptor configs to the v2 #15370

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

resoluteCoder
Copy link

SUMMARY

Updates the receptor configs: hop, awx, and worker to use the v2 config of receptor.

NOTE: do not merge until ansible/receptor#1043 is merged

Please comment if I missed any configs! Thanks!

ISSUE TYPE
  • Breaking Change
COMPONENT NAME
  • CLI
AWX VERSION
n/a
ADDITIONAL INFORMATION
n/a

@fosterseth
Copy link
Member

fosterseth commented Jul 31, 2024

I see this in the development environment

tools_awx_1       | 2024-07-31 21:55:27,009 ERROR    [-] awx.main.dispatch Encountered unhandled error in dispatcher main loop
tools_awx_1       | Traceback (most recent call last):
tools_awx_1       |   File "/awx_devel/awx/main/dispatch/worker/base.py", line 237, in run
tools_awx_1       |     self.worker.on_start()
tools_awx_1       |   File "/awx_devel/awx/main/dispatch/worker/task.py", line 141, in on_start
tools_awx_1       |     dispatch_startup()
tools_awx_1       |   File "/awx_devel/awx/main/tasks/system.py", line 117, in dispatch_startup
tools_awx_1       |     cluster_node_heartbeat()
tools_awx_1       |   File "/awx_devel/awx/main/tasks/system.py", line 575, in cluster_node_heartbeat
tools_awx_1       |     inspect_execution_and_hop_nodes(instance_list)
tools_awx_1       |   File "/awx_devel/awx/main/tasks/system.py", line 513, in inspect_execution_and_hop_nodes
tools_awx_1       |     ctl = get_receptor_ctl()
tools_awx_1       |           ^^^^^^^^^^^^^^^^^^
tools_awx_1       |   File "/awx_devel/awx/main/tasks/receptor.py", line 163, in get_receptor_ctl
tools_awx_1       |     receptor_sockfile = get_receptor_sockfile(config_data)
tools_awx_1       |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
tools_awx_1       |   File "/awx_devel/awx/main/tasks/receptor.py", line 138, in get_receptor_sockfile
tools_awx_1       |     for entry_name, entry_data in section.items():
tools_awx_1       |                                   ^^^^^^^^^^^^^
tools_awx_1       | AttributeError: 'str' object has no attribute 'items'

there is some rather unfortunate code in awx that opens the config file and parses it to introspect some properties of the locally running receptor. Ideally we woudn't do that, and instead just add some receptorctl command to get that info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants