Add back git requirements as comments #15317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
AlanCoding
commented
Jul 1, 2024
| @@ -77,6 +78,7 @@ botocore==1.34.47 | |||
| # s3transfer | |||
| cachetools==5.3.2 | |||
| # via google-auth | |||
| # git+https://github.com/ansible/system-certifi.git@devel # git requirements installed separately | |||
| # via | |||
| # -r /awx_devel/requirements/requirements_git.txt | |||
| # kubernetes | |||
There was a problem hiding this comment.
Now this is coherent output.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Making alternative to #15316
After diving into the issue further, I believe the approach in 15316 is untenable. Yes, it fixes things a little bit, but the output still doesn't make sense.
By going this route, and turning those into a comment, we have a fully complete file.
TODO: we should add a short comment explaining why we do this.ISSUE TYPE
COMPONENT NAME