-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create and register page types for the new RBAC endpoints #15275
base: devel
Are you sure you want to change the base?
Conversation
I hope and think that this should be as easy as:
|
|
||
|
||
page.register_page( | ||
[resources.role_team_assignment, (resources.role_definition_team_assignments, 'post'), (resources.role_team_assignments, 'post')], RoleTeamAssignment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resources.role_definition_team_assignments
would be read-only, so it looks like the most correct thing would be to delete it here.
|
||
|
||
page.register_page( | ||
[resources.role_user_assignment, (resources.role_definition_user_assignments, 'post'), (resources.role_user_assignments, 'post')], RoleUserAssignment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other thing worth noting is that assignments are immutable, meaning the detail endpoint, resources.role_user_assignment
, would not allow PATCH/PUT... but it seems that no references to the detail endpoint exist here in the first place, so I guess we're good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! this is a good step forward.
- left one minor request that the sublist shouldn't map POST to anything
- delete comments with imports of
HasCopy
and the like.
SUMMARY
Some new endpoints are being exposed, and old endpoints are now marked as deprecated. Update awxkit in order to properly support the new way in the cli, but also so that QE testing can start making use of the new stuff.
ISSUE TYPE
COMPONENT NAME