Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "updated patternfly" #11963

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

AlexSCorey
Copy link
Member

@AlexSCorey AlexSCorey commented Mar 25, 2022

SUMMARY

linked: #11467
Reverts a previous change to bring in a new patternfly Drop and Drop component. The problem with this component is that it does not support keyboard functionality and it does not look like PF is going to be able to address that change any time soon.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • UI

@AlexSCorey AlexSCorey force-pushed the 11467-RevertDraagandDrop branch 2 times, most recently from 1ce88df to 6abaa84 Compare March 28, 2022 14:51
@AlexSCorey AlexSCorey changed the title [WIP]Revert "updated patternfly" Revert "updated patternfly" Mar 28, 2022
@AlexSCorey
Copy link
Member Author

see patternfly/patternfly-react#6317.
I think our options right now are:

  1. Merge this PR and just deal with the deprecation warning, we will have to turn off unit tests that are failing due to the warning.
  2. Don't merge this pr and not have keyboard accessibility for drag/drop. @tiagodread @akus062381 @InnocentK do we have drag/drop accessibility tests turned on right now?

@tiagodread
Copy link
Contributor

he problem with this component is that it does not support keyboard functionality and it does not look like PF is going to be able to address that change any time soon.

No, the test was skipped when PF got upgraded

Copy link
Member

@marshmalien marshmalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested this out manually and keyboard drag and drop behaved as it should. PF has "Reevaluate DropDrop implementation" slated for their 2022.05 milestone. Do we know if this is actively being worked on @AlexSCorey?
These lines are causing the failures in our tests 🤔

@akus062381 akus062381 self-assigned this Mar 31, 2022
@akus062381
Copy link
Member

@AlexSCorey I think for now we continue with this revert PR, skip the unit tests in question, and keep the original issue open as a reminder to check patternfly's future updates that may resolve this

@AlexSCorey
Copy link
Member Author

@marshmalien I does not seem that PF is actively working on this. They have assigned it to several releases and keep kicking it down the road.

@akus062381 Sounds good!

@akus062381
Copy link
Member

@AlexSCorey something is blocking this from merging?

@cypress
Copy link

cypress bot commented Apr 5, 2022



Test summary

640 1 860 0Flakiness 0


Run details

Project AWX - Functional
Status Failed
Commit 89da443
Started Apr 5, 2022 12:27 AM
Ended Apr 5, 2022 2:15 AM
Duration 48:14 💡
OS Linux Debian - 10.11
Browser Chrome 98

View run in Cypress Dashboard ➡️


Failures

cypress/integration/organizations/organization-crud.spec.js Failed
1 Create Organization Galaxy credentials- further testing > Can create an org and reorg the credential order on edit

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@akus062381 akus062381 merged commit b5fcc6e into ansible:devel Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants