-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "updated patternfly" #11963
Revert "updated patternfly" #11963
Conversation
1ce88df
to
6abaa84
Compare
see patternfly/patternfly-react#6317.
|
No, the test was skipped when PF got upgraded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Tested this out manually and keyboard drag and drop behaved as it should. PF has "Reevaluate DropDrop implementation" slated for their 2022.05 milestone. Do we know if this is actively being worked on @AlexSCorey?
These lines are causing the failures in our tests 🤔
@AlexSCorey I think for now we continue with this revert PR, skip the unit tests in question, and keep the original issue open as a reminder to check patternfly's future updates that may resolve this |
@marshmalien I does not seem that PF is actively working on this. They have assigned it to several releases and keep kicking it down the road. @akus062381 Sounds good! |
6abaa84
to
89da443
Compare
@AlexSCorey something is blocking this from merging? |
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
89da443
to
ffb46fe
Compare
SUMMARY
linked: #11467
Reverts a previous change to bring in a new patternfly Drop and Drop component. The problem with this component is that it does not support keyboard functionality and it does not look like PF is going to be able to address that change any time soon.
ISSUE TYPE
COMPONENT NAME