Wrap ExecutionEnv Lookup in SettingGroup component. #11107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kialam
commented
Sep 22, 2021
AlexSCorey
requested changes
Sep 22, 2021
There was a problem hiding this comment.
Re: Validating the ExecutionEnvironmentLookup
I don't think we need to validate that look up because it isn't required anywhere in the project from what I can tell. However, if you do want to have validation on it I have made some suggestions below that seem to work and allow us to remove the setTimeout inside the <Lookup> component.
kialam
force-pushed
the
fix-10785-ee-revert-button
branch
from
6dd8f64 to
a114685
Compare
nixocio
suggested changes
Sep 23, 2021
nixocio
approved these changes
Sep 23, 2021
kialam
force-pushed
the
fix-10785-ee-revert-button
branch
from
a114685 to
f072839
Compare
kialam
force-pushed
the
fix-10785-ee-revert-button
branch
from
f072839 to
d7f1f0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Related #10785
This PR adds a Revert Button to the Execution Environment lookup in the Misc. Settings page.
ISSUE TYPE
COMPONENT NAME
AWX VERSION