Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix makefile ansible-operator URL #1696

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

dmzoneill
Copy link
Member

@dmzoneill dmzoneill commented Jan 25, 2024

The binary for ansible-operator v1.32.0 does not exist.

SUMMARY

The version hard coded 1.32.0 does not exist.
https://github.com/ansible/awx-operator/blob/devel/Makefile#L196

Only v1.31.0 is currently available
https://github.com/operator-framework/operator-sdk/releases
This PR sets it to 1.31.0 until a newer version becomes available.

https://github.com/operator-framework/operator-sdk/releases

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
ADDITIONAL INFORMATION

@kurokobo
Copy link
Contributor

@dmzoneill
Hi, simply it has been moved to under operator-framework/ansible-operator-plugins: https://github.com/operator-framework/ansible-operator-plugins/releases

@dmzoneill dmzoneill force-pushed the daoneill-ansible-operator branch 3 times, most recently from f2774dc to a2aff1f Compare January 29, 2024 12:31
@dmzoneill dmzoneill force-pushed the daoneill-ansible-operator branch from a2aff1f to 9b22c9b Compare January 29, 2024 12:31
@dmzoneill
Copy link
Member Author

@kurokobo I've updated the makefile to reference the indicated file locations.
Please review and merge if possible.

@dmzoneill dmzoneill changed the title Ansible operator > v1.31.0 not available Fix makefile ansible-operator URL Jan 29, 2024
Copy link
Contributor

@kurokobo kurokobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for updating.

Current AWX Operator is based on Operator SDK 1.32.0 instead of 1.33.0 nor 1.34.0 (#1651):

FROM quay.io/operator-framework/ansible-operator:v1.32.0

So if we want to fix Makefile I think the same version should be specified.

@dmzoneill dmzoneill merged commit a534c85 into devel Jan 29, 2024
11 checks passed
@dmzoneill dmzoneill deleted the daoneill-ansible-operator branch January 29, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants