1590 flag to control execution of the chmod/chown on backup data file #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@romankuzmik I looked into if there is/was a need for the underlying chmod + chown and I can not find one. I say just change your PR to just delete the chmod + chown task. |
TheRealHaoLiu
added a commit
to TheRealHaoLiu/awx-operator
that referenced
this pull request
Dec 13, 2023
|
Put up a PR for removing the chmod/chown altogether #1667 |
|
@romankuzmik Thank you for the PR, merging these changes in a separate PR here to get it in: |
rooftopcellist
pushed a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Depends on a storage driver configured for Backup PVC it might not be possible to change file mode or ownership on the backup file produced. This change introduces new flag that can turn off "chmod/chown".
If we run db-management pod as root, it does not matter that PVC volume mount would allow root group ownership.
Without pod's securityContext/fsGroup specified it would normally be nobody:nobody, instead of root:root. This "chown :root" might fail with some k8s storage drivers.
ISSUE TYPE
ADDITIONAL INFORMATION
See Issue 1590