Add AWXMeshIngress custom resource (require ansible/awx#14640 to function) #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealHaoLiu
force-pushed
the
feature_awx-mesh-ingress
branch
from
f42c9dd to
9202473
Compare
TheRealHaoLiu
force-pushed
the
feature_awx-mesh-ingress
branch
from
4272c0c to
b0233cd
Compare
TheRealHaoLiu
force-pushed
the
feature_awx-mesh-ingress
branch
from
9784b7f to
f09561c
Compare
TheRealHaoLiu
force-pushed
the
feature_awx-mesh-ingress
branch
2 times, most recently
from
991b09e to
39a2910
Compare
CFSNM
force-pushed
the
feature_awx-mesh-ingress
branch
from
f2f577e to
40fa551
Compare
TODO: register instance after creation dependent on API/CLI change
sample are used in CI for validation test in current implementation we only support openshift route this will not work on kind clusters correctly and having the sample is causing CI failure
TheRealHaoLiu
force-pushed
the
feature_awx-mesh-ingress
branch
5 times, most recently
from
75e1f18 to
4b7855a
Compare
| @@ -0,0 +1,19 @@ | |||
| # TODO: Add tests for AWXMeshIngress | |||
There was a problem hiding this comment.
Leaving this out of CI runs for now. @TheRealHaoLiu will address this in a future PR.
This bit will resolve that.
| spec: | ||
| containers: | ||
| - args: | ||
| - /bin/sh |
There was a problem hiding this comment.
Suggestion as a future improvement. We should configmap these commands in as a script, then this should just call that script. This can be done in a follow-up PR.
The mesh role now calls 1. awx-manage provision instance to register the hop node to the database 2. awx-manage add_receptor_address to register the internal address 3. awx-manage add_receptor_address to register the external address (to be used by remote nodes) CRD expanded to include external_ipaddress and external_hostname external_ipaddress is added as ipaddress in the hop node certificate external_hostname is added as dnsname in the hop node certificate the mesh role now checks for is_openshift and only creates a Route if true. Otherwise it will use external_hostname set in the spec file in place of Route name. Signed-off-by: Seth Foster <fosterbseth@gmail.com>
When pod loses connection with k8s api server, a statefulset can take a while (5 minutes) before it is rescheduled. Deployments quicker turnaround in this situation, which should help mesh stability. Signed-off-by: Seth Foster <fosterbseth@gmail.com>
- add --is_internal and --peers_from_control_nodes to indicate the address is internal Signed-off-by: Seth Foster <fosterbseth@gmail.com>
This way when AWX is deleted associated AWXMeshIngress will all be deleted as well
external_ipaddress is optional and we should be able to deal with missing external_ipaddress with no error
* fix: correct port number for internal receptor address * feat: add support for ingress for awxmeshingress cr * feat: add support for ingressroutetcp (for traefik) for awxmeshingress cr
also rename route.yml.j2 to ingress.yml.j2 since we cover more than just route now
and fix linting Signed-off-by: Seth Foster <fosterbseth@gmail.com> Set correct protocol for external mesh ingress address and fix linting error
TODO: fix this
TheRealHaoLiu
force-pushed
the
feature_awx-mesh-ingress
branch
from
4b7855a to
f533585
Compare
rooftopcellist
approved these changes
Jan 18, 2024
TheRealHaoLiu
changed the title
TheRealHaoLiu
changed the title
|
We will merge this first and continue to iterate on ansible/awx#14640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add new CRD for controlling deployment of Mesh Ingress node to AWX
NOTE: require ansible/awx#14640 to function
ISSUE TYPE
ADDITIONAL INFORMATION