Add compatibility code to the entrypoint so new EEs work with old runner version #988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #957 we combined 2 callback names (awx_display, minimal) into just 1, awx_display. Fundamentally, this makes it hard for the containers to work with ansible-runner versions before/after, and vice versa. Ping review by @shanemcd
In that PR, I paid attention to the ability for current ansible-runner to work with old images.
I was failing to fully appreciate the implications of old ansible-runner not working with current images.
This PR adds a shim to the entrypoint so that the image with work even if used by old versions of ansible-runner. In the PR 957 I removed the use of the
LAUNCHED_BY_RUNNER
environment variable. This allows using that as a poor proxy for the version of ansible-runner that is starting the container.@rebeccahhh pointed out to me that our tests for AAP controller 4.1.x were failing due to these problems. I've re-tested those with a custom image built from this branch,
quay.io/alancoding/ansible-runner:marty_youve_got_to_come_back_with_me
, and this gets them to pass.There's no reasonable way to ever get test coverage, because the whole idea is compatibility with old versions. So I am working on running
make test
with that custom image tagged asquay.io/ansible/ansible-runner:devel
while I have the commit f1b6c3a checked out, which was the last commit before the PR landed.