Add --ident option to process command

[AlanCoding]

Fixes #821

Below is my bash scripts where I emulate AWX behavior on hybrid nodes. I might document these in a repository sometime... maybe they would work for docs? Maybe not because I actually run them.

echo 'Initial cleanup tasks'
rm -rf overwrite
rm -rf demo/artifacts
mkdir overwrite
cp -Ra demo overwrite/1

ident='b20e75dd2a4049708f3ed10a73cad3cc'
echo "The ident for this run is: $ident"

echo 'Transmission phase - fills the first buffer'
ansible-runner transmit ./overwrite/1 -p test.yml --ident=$ident > ./overwrite/output1

echo 'Worker phase - fills second buffer'
ansible-runner worker --private-data-dir=./overwrite/1 < ./overwrite/output1 > ./overwrite/output2

echo 'Process phase - runs callbacks and pretty much nothing else'
ansible-runner process overwrite/1 --ident=$ident < ./overwrite/output2

tree overwrite

Long story short, this is how AWX works with a slight modification for how I think it should work, which is the added --ident option.

Without this, you have 2 files for overwrite/1/artifacts/rc and overwrite/1/artifacts/b20e75dd2a4049708f3ed10a73cad3cc/rc/. So which one is the right one? I want to avoid that confusion. Ping @jbradberry

[jbradberry]

I had this worry early on but then nothing ever seemed to come of it. Ultimately, I think this is a good idea.

[AlanCoding]

We could add more things to the ansible-runner process CLI, but the issue is that I frankly just don't need them. It's confusing from the code, but we don't have --artifact-dir. That's the one other notable absence I saw. In terms of all the other config parameters that affect job execution, we don't want them because the job is already off, and we can't change it.

[AlanCoding]

If you wanted, we could actually add the --artifact-dir, not add the --ident, and then not change anything about the streaming.py module. AWX could make due with that, no problem. If you consider ansible-runner run --help, both of these are options, so I figure they're both equally valid here.

[Shrews]

I believe this is most likely ok. I see ident is already documented in the interface.run() method(s). I've been trying to get this to work via the Python API to make sure it works that way, but I'm having some difficulty getting that working properly (probably usage error on my part, not a bug here).

[ansible-zuul]

LGTM!

[ansible-zuul]

Pull request merge failed: Resource not accessible by integration

[Shrews]

recheck

[goneri]

recheck

[goneri]

recheck

[goneri]

recheck

[Shrews]

recheck

[Shrews]

recheck

[ansible-zuul]

Pull request merge failed: Resource not accessible by integration