Additionally mount ~/.ssh/ to /root/.ssh inside EEs
#805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some background: paramiko looks for keys in $HOME/.ssh, $HOME in the EE is set to /home/runner this change will allow for both the use of paramiko and openssh within the EE, and keys being located in each of those default search paths (this all w/o ssh-agent) |
|
LGTM, except for needing test updates. |
samdoran
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Change looks good. The tests are failing due to a mismatch in expected order of options:
test/unit/config/test_ansible_cfg.py:92: AssertionError
AssertionError: assert '-v' == '--group-add=root'
Do we need to add new tests for this to ensure it doesn't break in the future?
ansible-zuul bot
added a commit
that referenced
this pull request
Sep 14, 2021
Fix unit tests to run consistently in CI and locally use pytest-mock and tmp_path fixtures mock test environment variables to prevent inconsistent test results reformat test fixtures so they are easier to read This will resolve the test failures in #805. Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com> Reviewed-by: Sam Doran <sdoran@redhat.com> Reviewed-by: Alan Rominger <arominge@redhat.com> Reviewed-by: David Shrewsbury <None> Reviewed-by: None <None>
|
recheck |
samdoran
changed the title
~/.ssh/ to /root/.ssh inside EEs
samdoran
changed the title
~/.ssh/ to /root/.ssh inside EEs~/.ssh/ to /root/.ssh inside EEs
shanemcd
force-pushed
the
mount-ssh-to-root
branch
from
792b4c7 to
fe3c1aa
Compare
|
Do we not need this anymore? It looks like the tests will need to be updated since a new mount is being added. I plan to refactor the command and object generation into common functions that can be shared. That will minimize the locations we need to change the tests when the code changes. |
ansible-zuul bot
added a commit
that referenced
this pull request
Sep 17, 2021
Additionally mount ~/.ssh/ to /root/.ssh inside EEs I accidentally closed #805 with a force-push and can't figure out how to reopen. Currently when running inside an EE as root, only SSH_AUTH_SOCK is working. This enables the usage of default key names under ~/.ssh/ on the host. Reviewed-by: David Shrewsbury <None> Reviewed-by: None <None>
samdoran
pushed a commit
to samdoran/ansible-runner
that referenced
this pull request
Oct 14, 2021
Fix unit tests to run consistently in CI and locally use pytest-mock and tmp_path fixtures mock test environment variables to prevent inconsistent test results reformat test fixtures so they are easier to read This will resolve the test failures in ansible#805. Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com> Reviewed-by: Sam Doran <sdoran@redhat.com> Reviewed-by: Alan Rominger <arominge@redhat.com> Reviewed-by: David Shrewsbury <None> Reviewed-by: None <None> (cherry picked from commit 2323686)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when running inside an EE as root, only
SSH_AUTH_SOCKis working.This enables the usage of default key names under
~/.ssh/on the host.