-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom integration python job #790
Conversation
recheck |
91aa690
to
07bc6c5
Compare
07bc6c5
to
b08d7da
Compare
b08d7da
to
035b3a7
Compare
bba6ff4
to
f0c2ebe
Compare
Seems @pabelanger I could not find the version of podman in use in the test logs. Any idea how I could figure that out? |
f0c2ebe
to
c293743
Compare
recheck |
1 similar comment
recheck |
523676a
to
3ad5396
Compare
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Backport to release_2.0: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply c654d1c on top of patchback/backports/release_2.0/c654d1cb821c06352170e7c189f4487eaa746702/pr-790 Backporting merged PR #790 into devel
🤖 @patchback |
Add custom integration python job Changes the tox py38 job to also parent to ansible-buildset-registry-consumer which will get us a container environment (either docker or podman) on the test node. This will cause several more tests, which are skipped if neither docker nor podman are installed, to actually run. Removes the following (now failing) tests that were left in when adhoc and playbook commands were removed: test_adhoc_localhost_setup test_playbook_with_private_data_dir test_playbook_with_relative_path The following tests were being skipped: test/integration/test_events.py::test_async_events test/integration/test_events.py::test_profile_data test/integration/test_display_callback.py::test_callback_plugin_records_notify_events[playbook0] test/integration/test_interface.py::test_run_script_within_container test/integration/test_interface.py::test_get_plugin_docs_within_container test/integration/test_events.py::test_basic_events[True] test/integration/test_interface.py::test_run_ansible_command_within_container test/integration/test_interface.py::test_get_inventory_within_container test/integration/test_interface.py::test_get_plugin_docs_list_within_container test/integration/test_transmit_worker_process.py::TestStreamingUsage::test_remote_job_by_sockets[adhoc] test/integration/test_transmit_worker_process.py::TestStreamingUsage::test_remote_job_by_sockets[run] test/integration/test_interface.py::test_env_accuracy_inside_container test/integration/containerized/test_cli_containerized.py::test_module_run test/integration/containerized/test_cli_containerized.py::test_playbook_run test/integration/containerized/test_cli_containerized.py::test_provide_env_var test/integration/containerized/test_cli_containerized.py::test_adhoc_localhost_setup test/integration/containerized/test_cli_containerized.py::test_playbook_with_private_data_dir test/integration/containerized/test_cli_containerized.py::test_playbook_with_relative_path test/integration/containerized/test_container_management.py::test_cancel_will_remove_container After this change, this is the remaining set of skipped tests: test/integration/test_events.py::test_async_events[True] test/integration/test_events.py::test_profile_data test/integration/test_display_callback.py::test_callback_plugin_records_notify_events[playbook0] test/integration/test_events.py::test_basic_events[True] Reviewed-by: Paul Belanger <None> Reviewed-by: David Shrewsbury <None> Reviewed-by: Shane McDonald <me@shanemcd.com> Reviewed-by: None <None> (cherry picked from commit c654d1c)
[release_2.0] Backport integration test Backports of: PR #790 - Add custom integration python job PR #796 - Migrate container jobs to centos-8-stream nodeset PR #797 - Tune tox.ini PR #798 - Rework bindep.txt files PR #801 - Small change to properly test containers Reviewed-by: Shane McDonald <me@shanemcd.com> Reviewed-by: None <None>
Changes the tox py38 job to also parent to
ansible-buildset-registry-consumer
which will get us a container environment (either docker or podman) on the test node. This will cause several more tests, which are skipped if neither docker nor podman are installed, to actually run.Removes the following (now failing) tests that were left in when
adhoc
andplaybook
commands were removed:The following tests were being skipped:
After this change, this is the remaining set of skipped tests: