PEP8 and setuptools cleanup #761
Conversation
Dashes in key names are deprecated.
| @@ -14,4 +14,3 @@ | |||
| for entry_point | |||
| in pkg_resources.iter_entry_points('ansible_runner.plugins') | |||
There was a problem hiding this comment.
As a side note, I strongly encourage migrating to importlib in place of pkg_resources
There was a problem hiding this comment.
I will have to do that in a separate PR.
There was a problem hiding this comment.
Also, while you're at it, I recommend you integrate
https://github.com/pre-commit/pre-commit-hooks#trailing-whitespace
into .pre-commit-config.yaml. And use pre-commit in the linters tox env so that it's actually being executed. This small change would help keep the project free of trailing whitespaces.
|
I didn't get to this today, but I will tomorrow. |
This reverts commit 34d3a0c.
|
recheck |
| max-line-length=160 | ||
| ignore=E201,E203,E221,E225,E231,E241,E251,E261,E265,E303,W291,W391,W293,E731,F405 | ||
| exclude=.tox,venv |
There was a problem hiding this comment.
While I'm on it, let me inform you that https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-exclude exists. Of course, it's best to change it in a separate PR too.
There was a problem hiding this comment.
I agree it would probably be better to use extend-exclude. The default list of .svn,CVS,.bzr,.hg,.git,__pycache__,.tox,.eggs,*.egg
| # W293 - Blank line contains whitespace | ||
| ignore=E201,E203,E221,E225,E231,E241,E251,E261,E265,E303,W291,W391,W293 | ||
| # W503 - Line break occurred before a binary operator | ||
| ignore=W503 |
There was a problem hiding this comment.
Do we even need this [pep8] section? We only run flake8 during the tests.
There was a problem hiding this comment.
Looks like that is only used my autopep8. If we have no plans to use that, we can remove it.
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
All the PEP8 rules that were ignored have to do with whitespace formatting which help keep the code readable. Fix all the rule violations and remove the ignored rules.