Make rotate_artifacts accessible from env/settings #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to ansible#1415 Make `rotate_artifacts` accessible from the settings file. * Modify `src/ansible_runner/config/_base.py`: - Retrieve `rotate_artifacts` from `settings` dictionary in `prepare_env` method. - Set `rotate_artifacts` in `__init__` method only if not provided in `settings` dictionary. - Ensure `rotate_artifacts` is set to 0 if not provided in command line or settings file. - Make `rotate_artifacts` default to 0 in `__init__` method. - Set `rotate_artifacts` from command line if provided. * Modify `demo/env/settings`: - Add `rotate_artifacts` option to the settings file. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/ansible/ansible-runner/issues/1415?shareId=XXXX-XXXX-XXXX-XXXX).
|
This one seems to work, only I wonder if the settings file should really win over the command line argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1415
Make
rotate_artifactsaccessible from the settings file.Modify
src/ansible_runner/config/_base.py:rotate_artifactsfromsettingsdictionary inprepare_envmethod.rotate_artifactsin__init__method only if not provided insettingsdictionary.rotate_artifactsis set to 0 if not provided in command line or settings file.rotate_artifactsdefault to 0 in__init__method.rotate_artifactsfrom command line if provided.Modify
demo/env/settings:rotate_artifactsoption to the settings file.For more details, open the Copilot Workspace session.