Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand env variable mentioned in the pull arguments (--pa) #1590

Merged
merged 6 commits into from
Sep 21, 2023
Merged

Expand env variable mentioned in the pull arguments (--pa) #1590

merged 6 commits into from
Sep 21, 2023

Conversation

shatakshiiii
Copy link
Contributor

Fixes: #1579

@shatakshiiii shatakshiiii added the bug Researched, reproducible, committed to fix label Aug 3, 2023
ssbarnea
ssbarnea previously requested changes Aug 29, 2023
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lacks any tests for the new behavior.

@shatakshiiii shatakshiiii self-assigned this Sep 18, 2023
@shatakshiiii shatakshiiii temporarily deployed to ack September 21, 2023 06:20 — with GitHub Actions Inactive
@shatakshiiii shatakshiiii temporarily deployed to ack September 21, 2023 10:08 — with GitHub Actions Inactive
@shatakshiiii shatakshiiii temporarily deployed to ack September 21, 2023 13:39 — with GitHub Actions Inactive
@shatakshiiii shatakshiiii temporarily deployed to ack September 21, 2023 13:40 — with GitHub Actions Inactive
@shatakshiiii shatakshiiii dismissed ssbarnea’s stale review September 21, 2023 14:05

addressed the review changes

@shatakshiiii shatakshiiii requested review from a team, ssbarnea, audgirka and Ruchip16 September 21, 2023 14:06
@shatakshiiii
Copy link
Contributor Author

Lacks any tests for the new behavior.

Added that test!

@shatakshiiii shatakshiiii temporarily deployed to ack September 21, 2023 14:23 — with GitHub Actions Inactive
@shatakshiiii shatakshiiii changed the title Expand env variable during pull Expand env variable mentioned in the pull arguments (--pa) Sep 21, 2023
@shatakshiiii shatakshiiii merged commit 0f817b2 into ansible:main Sep 21, 2023
@shatakshiiii shatakshiiii deleted the env_var_expansion branch September 21, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock cidrblock approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner automatically assigned from ansible/devtools

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@Ruchip16 Ruchip16 Awaiting requested review from Ruchip16 Ruchip16 is a code owner automatically assigned from ansible/devtools

Assignees

@shatakshiiii shatakshiiii

Labels
bug Researched, reproducible, committed to fix
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pull-arguments adding quotes to arguments
3 participants
@shatakshiiii @ssbarnea @cidrblock