Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update creator-ee version to 0.18.0 #1542

Merged
merged 4 commits into from
May 25, 2023
Merged

Update creator-ee version to 0.18.0 #1542

merged 4 commits into from
May 25, 2023

Conversation

shatakshiiii
Copy link
Contributor

Closes: #1532

@shatakshiiii shatakshiiii added the enhancement New feature or request label May 22, 2023
@shatakshiiii shatakshiiii marked this pull request as ready for review May 25, 2023 09:06
@shatakshiiii shatakshiiii requested review from cidrblock, a team, ssbarnea, audgirka and Ruchip16 May 25, 2023 09:07
ssbarnea
ssbarnea approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, the big question is if we can remove some of these fixtures, so we would not need to update 80 files on every creator-ee bump.

@ssbarnea ssbarnea merged commit 2aac257 into ansible:main May 25, 2023
@shatakshiiii shatakshiiii deleted the update_cee branch May 25, 2023 09:34
@shatakshiiii
Copy link
Contributor Author

Looks ok, the big question is if we can remove some of these fixtures, so we would not need to update 80 files on every creator-ee bump.

These fixtures largely affect the integration tests we have, for each action (images in this case). That's why we end up updating all those files.

@shatakshiiii shatakshiiii self-assigned this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyamsahoo priyamsahoo priyamsahoo approved these changes

@audgirka audgirka audgirka approved these changes

@ssbarnea ssbarnea ssbarnea approved these changes

@cidrblock cidrblock Awaiting requested review from cidrblock

@Ruchip16 Ruchip16 Awaiting requested review from Ruchip16 Ruchip16 is a code owner automatically assigned from ansible/devtools

Assignees

@shatakshiiii shatakshiiii

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shatakshiiii @ssbarnea @audgirka @priyamsahoo