Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove share directory #1467

Merged
merged 6 commits into from
Mar 28, 2023
Merged

Remove share directory #1467

merged 6 commits into from
Mar 28, 2023

Conversation

cidrblock
Copy link
Collaborator

  • Move the 2 scripts into the data directory in the src tree
  • At app initialization, copy, if needed, those scripts to the user's cache dir
  • Mount and run each script from that directory
  • Delete unused share directory and related configuration and discovery code.

Update tests as needed

Closes #83

@cidrblock cidrblock added the bug Researched, reproducible, committed to fix label Mar 27, 2023
@cidrblock
Copy link
Collaborator Author

Nothing to do about the codecov right now.

@cidrblock cidrblock merged commit 333239a into ansible:main Mar 28, 2023
@shatakshiiii shatakshiiii mentioned this pull request Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatakshiiii shatakshiiii shatakshiiii approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea

Assignees
No one assigned
Labels
bug Researched, reproducible, committed to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pare/remove share dir
2 participants
@cidrblock @shatakshiiii