Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to direct access a playbook provided by a collection for :run subcommand #1440

Merged
merged 12 commits into from
Mar 22, 2023
Merged

Add support to direct access a playbook provided by a collection for :run subcommand #1440

merged 12 commits into from
Mar 22, 2023

Conversation

shatakshiiii
Copy link
Contributor

@shatakshiiii shatakshiiii commented Feb 13, 2023 •
edited
Loading

Summary:

This PR adds support for FQCN playbook in navigator i.e. namespace.collection.playbook_name format.
Fixes: #1385

@shatakshiiii shatakshiiii added the bug Researched, reproducible, committed to fix label Feb 13, 2023
@shatakshiiii shatakshiiii changed the title Add support for :run to direct access a playbook provided by collection Add support to direct access a playbook provided by a collection for :run subcommand Feb 13, 2023
@shatakshiiii shatakshiiii marked this pull request as ready for review March 20, 2023 03:40
@cidrblock cidrblock enabled auto-merge (squash) March 22, 2023 20:52
@cidrblock cidrblock merged commit 6608a8c into ansible:main Mar 22, 2023
@shatakshiiii
Copy link
Contributor Author

Thanks @sivel for those detailed comments, it helped a lot!

@shatakshiiii shatakshiiii deleted the parse_playbook branch March 23, 2023 01:09
@shatakshiiii shatakshiiii self-assigned this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivel sivel sivel left review comments

@cidrblock cidrblock cidrblock approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

@Ruchip16 Ruchip16 Awaiting requested review from Ruchip16 Ruchip16 is a code owner automatically assigned from ansible/devtools

Assignees

@shatakshiiii shatakshiiii

Labels
bug Researched, reproducible, committed to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible-navigator run can't directly access a playbook provided by a collection
3 participants
@shatakshiiii @sivel @cidrblock