Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move directory containing grammar files into source tree #1408

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Move directory containing grammar files into source tree #1408

merged 3 commits into from
Jan 19, 2023

Conversation

cidrblock
Copy link
Collaborator

@cidrblock cidrblock commented Jan 19, 2023 •
edited
Loading

This moves the grammar files into the source tree out of the share directory

  • Update types as needed
  • Adjust for directory name change in spell checkers
  • Adjust prettier configuration
  • Remove share_dir parameter for print_to_stdout, adjust callers as needed

Small fix related to #1406 - Remove theme dir from prettier config

@cidrblock cidrblock added the bug Researched, reproducible, committed to fix label Jan 19, 2023
@cidrblock cidrblock merged commit 7072c43 into ansible:main Jan 19, 2023
@cidrblock cidrblock mentioned this pull request Jan 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatakshiiii shatakshiiii shatakshiiii approved these changes

@ssbarnea ssbarnea ssbarnea approved these changes

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug Researched, reproducible, committed to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cidrblock @ssbarnea @shatakshiiii