Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#975: ensure to use expand user and vars in paths #976

Merged
merged 3 commits into from
Aug 20, 2020
Merged

#975: ensure to use expand user and vars in paths #976

merged 3 commits into from
Aug 20, 2020

Conversation

ksmets
Copy link
Contributor

@ksmets ksmets commented Aug 19, 2020 •
edited
Loading

This closes #975

@ksmets ksmets changed the title ISSUE-975: ensure to use expand user and vars in paths ensure to use expand user and vars in paths Aug 19, 2020
@ksmets ksmets changed the title ensure to use expand user and vars in paths ISSUE-975: ensure to use expand user and vars in paths Aug 19, 2020
@ksmets ksmets changed the title ISSUE-975: ensure to use expand user and vars in paths #975: ensure to use expand user and vars in paths Aug 19, 2020
ssbarnea
ssbarnea requested changes Aug 20, 2020
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is incomplete as it does not contain any regression measure. A test must be present for such a change in order to avoid regression.

@ksmets
Copy link
Contributor Author

ksmets commented Aug 20, 2020 •
edited
Loading

@ssbarnea I've added the requested test.

@ssbarnea ssbarnea added the bug label Aug 20, 2020
@ssbarnea ssbarnea added this to the 4.3.0.1 milestone Aug 20, 2020
@ssbarnea ssbarnea merged commit a52c60f into ansible:master Aug 20, 2020
@ssbarnea ssbarnea modified the milestones: 4.3.0.1, 4.3.1 Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.3.1
Development

Successfully merging this pull request may close these issues.

~ and environment variables are not expanded properly both as cli arguments or as in config files
2 participants
@ksmets @ssbarnea