Refactored import_playbook tests #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awcrosby
reviewed
Aug 13, 2020
Updated our import_playbook tests to match ansible implementation of import_playbook and to avoid hitting ansible syntax check failures with our own testing playbooks. Needed-By: #950
ssbarnea
force-pushed
the
fix/import_playbook
branch
from
63434b5
to
88c1904
Compare
awcrosby
approved these changes
Aug 13, 2020
webknjaz
approved these changes
Aug 13, 2020
rafaelfolco
approved these changes
Aug 13, 2020
| assert len(results) == 2 | ||
| # Assures we detected the issues from imported playbook | ||
| assert 'Commands should not change things' in results_text | ||
| assert '502' in results_text |
| - hosts: localhost | ||
| tasks: | ||
| - command: echo "no name" # noqa 502 | ||
| post_tasks: |
There was a problem hiding this comment.
no longer importing as post_tasks, hope this does not lose coverage
There was a problem hiding this comment.
Yeah. This is what I wanted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated our import_playbook tests to match Ansible implementation of import_playbook and to avoid hitting Ansible syntax check failures with our own testing playbooks.
Ansible can only import playbooks at top level, not via tasks thus our testing was incorrect.
Needed-By: #950