-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linter branding for docs #914
Conversation
ssbarnea
commented
Jul 24, 2020
•
edited
Loading
edited
- Add linter logo and favicon that renders ok with light/dark themes
- Corrects documentation title
Note to reviewers, client the docs job and look at browser favicon, you should see a gray shield with Ansible "A" on top of it, a design that works with both day/night themes. |
- Add linter logo and favicon that renders ok with light/dark themes - Corrects documentation title
@ssbarnea why isn't |
Because filename is hardcoded in the theme. We can look into making it configurable in the future. |
Then, I'd postpone it until we do so. Adding+removing binaries from Git make the repo bigger unnecessarily. |
We are talking about a 5kb image, not 5mb one. It is smaller than most of our source codes. If would have being >200kb it would have made sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an improvement, thanks @ssbarnea.