Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter branding for docs #914

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Add linter branding for docs #914

merged 2 commits into from
Jul 24, 2020

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jul 24, 2020

  • Add linter logo and favicon that renders ok with light/dark themes
  • Corrects documentation title

@ssbarnea
Copy link
Member Author

Note to reviewers, client the docs job and look at browser favicon, you should see a gray shield with Ansible "A" on top of it, a design that works with both day/night themes.

- Add linter logo and favicon that renders ok with light/dark themes
- Corrects documentation title
@ssbarnea ssbarnea changed the title Add a favicon for the linter Add linter branding for docs Jul 24, 2020
@webknjaz
Copy link
Member

webknjaz commented Jul 24, 2020

@ssbarnea why isn't logo_invert.png SVG? I'd like to avoid adding bitmap images and only keep the vector ones...

@ssbarnea
Copy link
Member Author

@ssbarnea why isn't logo_invert.png SVG?

Because filename is hardcoded in the theme. We can look into making it configurable in the future.

@webknjaz
Copy link
Member

@ssbarnea why isn't logo_invert.png SVG?

Because filename is hardcoded in the theme. We can look into making it configurable in the future.

Then, I'd postpone it until we do so. Adding+removing binaries from Git make the repo bigger unnecessarily.

@ssbarnea
Copy link
Member Author

@ssbarnea why isn't logo_invert.png SVG?

Because filename is hardcoded in the theme. We can look into making it configurable in the future.

Then, I'd postpone it until we do so. Adding+removing binaries from Git make the repo bigger unnecessarily.

We are talking about a 5kb image, not 5mb one. It is smaller than most of our source codes. If would have being >200kb it would have made sense.

Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement, thanks @ssbarnea.

@webknjaz webknjaz merged commit e675aa2 into ansible:master Jul 24, 2020
@ssbarnea ssbarnea deleted the fix/favicon branch July 25, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants