Assure we do not produce duplicated matches #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
suggested changes
Jul 23, 2020
There was a problem hiding this comment.
This is missing tests for cases with MatchError being the same except for different MatchError.line. Per https://github.com/ansible/ansible-lint/pull/881/files#r451486472.
I think this is introducing a regression without that.
Due to the way we parse files it is possible to get duplicated matches. This change avoids printing duplications and also assures no regressions are made. Our examples/example.yml was not used during testing and was a good example that caused duplicates. Now we test it and assure we find the exact number of matches that we were expecting.
Refactoring to details removed this issue. Now details matters and different value will be counted. |
webknjaz
approved these changes
Jul 24, 2020
ssbarnea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way we parse files it is possible to get duplicated matches.
This change avoids printing duplications and also assures no regressions are made.
Our
examples/example.ymlwas not used during testing and was a good example that caused duplicates. Now we test it and assure we find the exact number of matches that we were expecting.