-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ansible210 testing #888
Conversation
tox.ini
Outdated
# TODO(ssbarnea): Replace replace the two tarbals created by @abadger1999 once | ||
# we official (pre-)releases are available on pypi.org | ||
ansibledevel: ansible-base @ https://toshio.fedorapeople.org/ansible/acd/ansible-base/ansible-base-2.10.0.dev1.tar.gz#egg=ansible-base | ||
ansibledevel: ansible @ https://toshio.fedorapeople.org/ansible/acd/ansible/ansible-2.10.0.tar.gz#egg=ansible | ||
ansibledevel: ansible @ git+https://github.com/ansible/ansible#egg=ansible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect. What this is pointing at is base:
ansibledevel: ansible @ git+https://github.com/ansible/ansible#egg=ansible | |
ansibledevel: ansible-base @ git+https://github.com/ansible/ansible.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious if @abadger has any plans to build nightlies for ACD...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abadger could you point to the ACD build script? maybe we could generate something for ourselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/ansible-community/antsibull/blob/main/docs/build-ansible.rst#building-ansible
For 2.10, we use the build-single strategy (not build-multiple or build-collection). The instructions have one problem due to a bug in the way the script assigns default values to the deps-file. Leave out --deps-file ansible-build-data/2.10/acd-2.10.0.deps
when you build-single and it should work. The deps file will end up in the same directory as the tarball then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python -m pip install --user --upgrade --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple ansible
@abadger FYI this doesn't make much sense: this does not set preference for indexes. Using just --extra-index-url https://test.pypi.org/simple/
would give the same result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's merge it as is and explore nightlies separately. It seems to be working in the CI so it's good enough right now.
Instead of using devel branch which is now 2.11, switch back to pypi versions for 2.10 testing.
Related: ansible/ansible#70705