Combine MatchError into Match #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Jul 5, 2020
webknjaz
reviewed
Jul 5, 2020
Combine two very similar classes in order to avoid extra complexity in processing rule validates. From now on a Match is an Exception so it can be raised, captured, and annotated in various places in the call stack.
albinvass
approved these changes
Jul 6, 2020
webknjaz
previously requested changes
Jul 6, 2020
|
zuul issue is infra related, reported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine two very similar classes in order to avoid extra complexity
in processing rule validates.
From now on a Match is an Exception so it can be raised, captured,
and annotated in various places in the call stack.