-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exclude_paths from get_playbooks_and_roles #774
Conversation
@cans That mention PR is huge and contains lots of unrelated changes. A PR should be kept atomic, addressing one issue, so it can easily be reviewed, merged and eventually identified if a regression occurs. Also the code complexity is unrelated to this bug and should be addressed separately. |
@cans I'll be glad to review the rest of the changes when submitted separately. It so happened that another PR fixed the issue and was easier to review and accept (because unrelated changes often have problems that block the whole PR even if the related changes are fine because it's hard to identify which part of the change is acceptable to merge already). @ssbarnea I'd like to encourage you to let PR authors complete their changes if they are not urgent and received updates during the last two weeks. This way we can focus on non-conflicting changes and work in more improvement directions w/o dismissing the hard work that other folks try to contribute. |
Fix bug which made impossible to use relative exclude paths as these where resolved while the file tested where not.
Fix bug which made impossible to use relative exclude paths as
these where resolved while the file tested where not.