Update ComparisonToEmptyStringRule.py #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditionals with bare variables will be deprecated. It's causing a lint warning atm. See CONDITIONAL_BARE_VARS https://docs.ansible.com/ansible/latest/reference_appendices/config.html#conditional-bare-vars
|
While the change is ok, I cannot accept it like this because you should also update the docs so that the CI doesn't fail: https://github.com/ansible/ansible-lint/pull/770/checks?check_run_id=652398319#step:10:53. |
Thank you for the review. I've updated the docs and submitted PR #772 Will you be able to squash and merge #770 and #772 ? |
|
Just update this PR, it'll only be green if they are together. |
|
@vbotka Please close the doc update and include it here. This can be avoided by always running |
|
Done. "tox -e lint" passed before the push. Thank you for comments. |
|
Looks green to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditionals with bare variables will be deprecated. It's causing a lint warning atm. See CONDITIONAL_BARE_VARS https://docs.ansible.com/ansible/latest/reference_appendices/config.html#conditional-bare-vars