Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging configuration #757

Merged
merged 1 commit into from
May 5, 2020
Merged

Fix logging configuration #757

merged 1 commit into from
May 5, 2020

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented May 4, 2020

Assure logging is initialized in such way that all submodules use
the module settings.

Previously initialize_setup() did configure logging only for
ansiblelint.utils, which means that any other ansiblelint.* would
not use the same settings.

Adds a debug level logging of loaded options.

lib/ansiblelint/utils.py Outdated Show resolved Hide resolved
lib/ansiblelint/utils.py Outdated Show resolved Hide resolved
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssbarnea this deserves a regression test.

Assure logging is initialized in such way that all submodules use
the module settings.

Previously initialize_setup() did configure logging only for
`ansiblelint.utils`, which means that any other ansiblelint.* would
not use the same settings.

Adds a debug level logging of loaded options.
@webknjaz webknjaz merged commit 8f77488 into ansible:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants