Enable YAML 1.2 support for non-ansible files

[ssbarnea]

Fixes: #3790

Fixed

[cidrblock]

It might just be me, but the conditional in here feels odd, it might be longer but can it go outside?

if file.is_owned_by_ansible():
  yaml = FormattedYAML(version=(1,1))
else:
  yaml = FormattedYAML(version=(1,2))

(somthing like that?)

or

if file.is_owned_by_ansible():
  version=(1,1)
else:
  version=(1,2)
yaml=FormattedYAML(version=version)

or

version = (1,1) if file.is_owned_by_ansible() else (1,2)
yaml=FormattedYAML(version=version)

[ssbarnea]

There reason why I wanted to fallback to null was because that would make it make it future-proof for when ruamel.yaml will switch to versions such 1.3 or more.

What we want is to override the default for ansible file, and not touch it for others.

[cognifloyd]

Agreed. We should stick with None as the default value.

[cognifloyd]

The purpose of relying on the presence/absence of the _yaml_version* attributes was not clear to me. What about using a separate _strip_yaml_version_directive attribute to define that explicitly instead of implying it using hasattr?

[cognifloyd]

Suggested change

	if version:
	if isinstance(version, str):
	x, y = version.split(".", maxsplit=1)
	version = (int(x), int(y))
	self._yaml_version_default: VersionType = version
	self._yaml_version: VersionType = self._yaml_version_default
	if isinstance(version, str):
	x, y = version.split(".", maxsplit=1)
	version = (int(x), int(y))
	self._yaml_version_default: VersionType | None = version
	self._yaml_version: VersionType | None = self._yaml_version_default
	self._strip_yaml_version_directive = version is not None

[ssbarnea]

I do not want to touch this right now, especially as I know that a newer patch of the library introduces some data that we might want to use, look at 0.18.4 changelog entries https://pypi.org/project/ruamel.yaml/

We can do extra polishing in follow-up, but I prefer to use whatever they have instead of setting new properties that have meaning only for our subclass. I need to play with it bit more too see what data I have available.

[cognifloyd]

Suggested change

	if hasattr(self, "_yaml_version"):
	return self._yaml_version
	return None
	return self._yaml_version

[cognifloyd]

Suggested change

	strip_version_directive = hasattr(self, "_yaml_version_default")
	return self._post_process_yaml(
	text,
	strip_version_directive=strip_version_directive,
	)
	return self._post_process_yaml(
	text,
	strip_version_directive=self._strip_yaml_version_directive,
	)